BuiltinBotFrameworkAuthentication.GetAppId try to check (appid/azp) before (aud) #6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangyangci
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6725
Description
BuiltinBotFrameworkAuthentication.GetAppId get appid from claim appid/azp before aud.
Because token from AAD also contains claim aud, but token from ABS don't have claim appid/azp.
While using User Assigned Managed Identity,
after Microsoft.Identity.Client version update to 4.55 from 4.50 (#6643)
The aud won't be appid.
Specific Changes
BuiltinBotFrameworkAuthentication.GetAppId will try to get appid from claim (appid/azp) than claim(aud).
Testing
ABS token example:
User Assigned Managed Identity AAD token example:
