Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ANTLR when LU content contains only comments #6747

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

sw-joelmut
Copy link
Collaborator

#minor

Description

This PR fixes an issue when using LU content with only comments.

Specific Changes

  • Revert previous changes related to addressing when using only comments, as the solution caused a few problems inside nested functionalities.

Testing

The following image shows the tests passing successfully and a testing case that detected a previous solution failure (which is not included in the source code yet).
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner February 7, 2024 20:19
@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label Feb 7, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 384416

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 78.4%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector.Streaming/Application/TimerAwaitable.cs 1 68.25%
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
Totals Coverage Status
Change from base Build 384373: 0.009%
Covered Lines: 26184
Relevant Lines: 33398

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 23c03d8 into main Feb 9, 2024
9 of 11 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/antrl-lu-only-comments branch February 9, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants