Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#6746] Move SaveAllChanges method from SetProperty to OAuthInput #6757

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #6746

Description

This PR moves the SaveAllChanges functionality from the SetProperty and SetProperties classes to the OAuthInput class.
Additionally, addressing the old issue (microsoft/BotFramework-Composer#9533), that introduced this change.

Specific Changes

  • Removed SetProperty and SetProperties SaveAllChanges functionality, as it was causing message duplication in the Slack adapter.
  • Added the SaveAllChanges functionality to the OAuthInput class, before sending the OAuthCard from the Skill to the Root to exchange the SSO token, and not loose state.

Testing

The following image shows an SSO bot working, retrieving the user's state after exchanging the token, correctly.
image

@sw-joelmut sw-joelmut added the Automation: Parity with js The PR needs to be ported to JS label Mar 7, 2024
@sw-joelmut sw-joelmut requested a review from a team as a code owner March 7, 2024 19:03
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 385861

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.005%) to 78.404%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SetProperty.cs 1 60.0%
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/OAuthInput.cs 32 52.21%
Totals Coverage Status
Change from base Build 385734: 0.005%
Covered Lines: 26187
Relevant Lines: 33400

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit b9192f8 into main Mar 18, 2024
10 of 11 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/move-saveallchanges branch March 18, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Multiple Messages in Slack Bot Channel after Updating to Microsoft Bot Builder SDK Version 4.22.0
3 participants