Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#6825] Update moq #6831

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: [#6825] Update moq #6831

merged 2 commits into from
Aug 5, 2024

Conversation

JhontSouth
Copy link
Collaborator

@JhontSouth JhontSouth commented Jul 31, 2024

Addresses #6825
#minor

Description

This PR updates the moq version in the unit test projects and fixes the compatibility issues that appeared after the update.

Specific Changes

  • Updated moq from 4.13.1 to 4.20.7
  • Fixed use of IsNullOrEmpty method in TextPromptWithNaughtyStrings unit test.

Testing

The following image shows the unit test running successfully.
image

@JhontSouth JhontSouth added the Automation: No parity PR does not need to be applied to other languages. label Jul 31, 2024
@JhontSouth JhontSouth requested a review from a team as a code owner July 31, 2024 14:51
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll

@tracyboehrer tracyboehrer merged commit 5c5cf2b into main Aug 5, 2024
10 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/moq branch August 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants