Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6825] Update Threading.Analyzers #6834

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #6825
#minor

Description

This PR updates the Microsoft.VisualStudio.Threading.Analyzers from 15.8.122 to 17.10.48, and fixes the VSTHRD200 issue with internal methods.

Specific Changes

  • Updated Microsoft.VisualStudio.Threading.Analyzers to latest version in BotBuilder and VSIX projects.
  • Updated some internal methods that required the Async suffix due to the VSTHRD200 error alert.

Testing

The following image shows the CI pipeline working, and an echo bot generated with VSIX templates.
image

@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label Aug 1, 2024
@sw-joelmut sw-joelmut requested a review from tracyboehrer August 1, 2024 13:05
@sw-joelmut sw-joelmut requested a review from a team as a code owner August 1, 2024 13:05
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

@tracyboehrer tracyboehrer merged commit 3f3cb74 into main Aug 5, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/threading-analyzers branch August 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants