Fix eslint issues in botbuilder-lg (#4803)

microsoft · Dec 9, 2024 · 64a10b1 · 64a10b1
1 parent 925a2c6
commit 64a10b1
Show file tree

Hide file tree

Showing 19 changed files with 512 additions and 497 deletions.
diff --git a/libraries/botbuilder-lg/eslint.config.cjs b/libraries/botbuilder-lg/eslint.config.cjs
@@ -1,13 +1,8 @@
-const onlyWarn = require("eslint-plugin-only-warn");
-const sharedConfig = require("../../eslint.config.cjs")
+const sharedConfig = require('../../eslint.config.cjs');
 
 module.exports = [
     ...sharedConfig,
     {
-        ignores: ["**/generated/*"],
+        ignores: ['**/generated/*'],
     },
-    {
-        plugins: {
-            "only-warn": onlyWarn,
-        },
-    }];
+];
diff --git a/libraries/botbuilder-lg/package.json b/libraries/botbuilder-lg/package.json
@@ -21,7 +21,6 @@
   "dependencies": {
     "adaptive-expressions": "4.1.6",
     "antlr4ts": "0.5.0-alpha.4",
-    "eslint-plugin-only-warn": "^1.1.0",
     "lodash": "^4.17.19",
     "uuid": "^10.0.0"
   },

diff --git a/libraries/botbuilder-lg/src/analyzer.ts b/libraries/botbuilder-lg/src/analyzer.ts
@@ -1,4 +1,3 @@
-/* eslint-disable security/detect-object-injection */
 /**
  * @module botbuilder-lg
  */
@@ -16,7 +15,7 @@ import { LGTemplateParserVisitor } from './generated/LGTemplateParserVisitor';
 import { Template } from './template';
 import { TemplateExtensions } from './templateExtensions';
 import { Templates } from './templates';
-import keyBy = require('lodash/keyBy');
+import keyBy from 'lodash/keyBy';
 
 import {
     IfConditionRuleContext,
@@ -37,7 +36,8 @@ import { TemplateErrors } from './templateErrors';
  */
 export class Analyzer
     extends AbstractParseTreeVisitor<AnalyzerResult>
-    implements LGTemplateParserVisitor<AnalyzerResult> {
+    implements LGTemplateParserVisitor<AnalyzerResult>
+{
     /**
      * Templates.
      */
@@ -85,7 +85,7 @@ export class Analyzer
                 throw new Error(
                     `${TemplateErrors.loopDetected} ${this.evalutationTargetStack
                         .reverse()
-                        .map((e) => e.templateName)} => ${templateName}`
+                        .map((e) => e.templateName)} => ${templateName}`,
                 );
             }
         }

diff --git a/libraries/botbuilder-lg/src/customizedMemory.ts b/libraries/botbuilder-lg/src/customizedMemory.ts
@@ -63,7 +63,6 @@ export class CustomizedMemory implements MemoryInterface {
      * @param _path Memory path.
      * @param _value Value to set.
      */
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     setValue(_path: string, _value: any): void {
         return;
     }

diff --git a/libraries/botbuilder-lg/src/diagnostic.ts b/libraries/botbuilder-lg/src/diagnostic.ts
@@ -43,7 +43,7 @@ export class Diagnostic {
         message: string,
         severity: DiagnosticSeverity = DiagnosticSeverity.Error,
         source?: string,
-        code?: string
+        code?: string,
     ) {
         this.message = message;
         this.range = range;

diff --git a/libraries/botbuilder-lg/src/errorListener.ts b/libraries/botbuilder-lg/src/errorListener.ts
@@ -48,22 +48,21 @@ export class ErrorListener implements ANTLRErrorListener<void> {
         offendingSymbol: any,
         line: number,
         charPositionInLine: number,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         msg: string,
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        e: RecognitionException | undefined
+        e: RecognitionException | undefined,
     ): void {
         const startPosition: Position = new Position(this.lineOffset + line, charPositionInLine);
         const stopPosition: Position = new Position(
             this.lineOffset + line,
-            charPositionInLine + offendingSymbol.stopIndex - offendingSymbol.startIndex + 1
+            charPositionInLine + offendingSymbol.stopIndex - offendingSymbol.startIndex + 1,
         );
         const range: Range = new Range(startPosition, stopPosition);
         const diagnostic: Diagnostic = new Diagnostic(
             range,
             TemplateErrors.syntaxError(msg),
             DiagnosticSeverity.Error,
-            this.source
+            this.source,
         );
 
         throw new TemplateException(diagnostic.toString(), [diagnostic]);

diff --git a/libraries/botbuilder-lg/src/evaluationOptions.ts b/libraries/botbuilder-lg/src/evaluationOptions.ts
@@ -1,4 +1,3 @@
-/* eslint-disable security/detect-object-injection */
 /**
  * @module botbuilder-lg
  */