apply code feedback

microsoft · Sep 11, 2023 · 6e0359d · 6e0359d
1 parent c88df50
commit 6e0359d
Show file tree

Hide file tree

Showing 8 changed files with 133 additions and 393 deletions.
diff --git a/libraries/botbuilder/etc/botbuilder.api.md b/libraries/botbuilder/etc/botbuilder.api.md
@@ -11,7 +11,9 @@ import { AppBasedLinkQuery } from 'botbuilder-core';
 import { AppCredentials } from 'botframework-connector';
 import { AttachmentData } from 'botbuilder-core';
 import { AuthenticationConfiguration } from 'botframework-connector';
+import { BatchFailedEntriesResponse } from 'botbuilder-core';
 import { BatchOperationResponse } from 'botbuilder-core';
+import { BatchOperationStateResponse } from 'botbuilder-core';
 import { BotAdapter } from 'botbuilder-core';
 import { BotConfigAuth } from 'botbuilder-core';
 import { BotFrameworkAuthentication } from 'botframework-connector';
@@ -36,8 +38,6 @@ import { ConversationState } from 'botbuilder-core';
 import { CoreAppCredentials } from 'botbuilder-core';
 import { ExtendedUserTokenProvider } from 'botbuilder-core';
 import { FileConsentCardResponse } from 'botbuilder-core';
-import { GetFailedEntriesResponse } from 'botbuilder-core';
-import { GetOperationStateResponse } from 'botbuilder-core';
 import { HttpClient } from '@azure/ms-rest-js';
 import { HttpOperationResponse } from '@azure/ms-rest-js';
 import { ICredentialProvider } from 'botframework-connector';
@@ -461,13 +461,13 @@ export function teamsGetTenant(activity: Activity): TenantInfo | null;
 // @public
 export class TeamsInfo {
     static cancelOperation(context: TurnContext, operationId: string): Promise<CancelOperationResponse>;
-    static getFailedEntries(context: TurnContext, operationId: string): Promise<GetFailedEntriesResponse>;
+    static getFailedEntries(context: TurnContext, operationId: string): Promise<BatchFailedEntriesResponse>;
     static getMeetingInfo(context: TurnContext, meetingId?: string): Promise<TeamsMeetingInfo>;
     static getMeetingParticipant(context: TurnContext, meetingId?: string, participantId?: string, tenantId?: string): Promise<TeamsMeetingParticipant>;
     static getMember(context: TurnContext, userId: string): Promise<TeamsChannelAccount>;
     // @deprecated
     static getMembers(context: TurnContext): Promise<TeamsChannelAccount[]>;
-    static getOperationState(context: TurnContext, operationId: string): Promise<GetOperationStateResponse>;
+    static getOperationState(context: TurnContext, operationId: string): Promise<BatchOperationStateResponse>;
     static getPagedMembers(context: TurnContext, pageSize?: number, continuationToken?: string): Promise<TeamsPagedMembersResult>;
     static getPagedTeamMembers(context: TurnContext, teamId?: string, pageSize?: number, continuationToken?: string): Promise<TeamsPagedMembersResult>;
     static getTeamChannels(context: TurnContext, teamId?: string): Promise<ChannelInfo[]>;

diff --git a/libraries/botbuilder/src/teamsInfo.ts b/libraries/botbuilder/src/teamsInfo.ts
@@ -26,8 +26,8 @@ import {
     MeetingNotificationResponse,
     TeamsMember,
     BatchOperationResponse,
-    GetOperationStateResponse,
-    GetFailedEntriesResponse,
+    BatchOperationStateResponse,
+    BatchFailedEntriesResponse,
 } from 'botbuilder-core';
 import {
     CancelOperationResponse,
@@ -495,7 +495,7 @@ export class TeamsInfo {
      * @param operationId The operationId to get the state of.
      * @returns Promise with The state and responses of the operation.
      */
-    static async getOperationState(context: TurnContext, operationId: string): Promise<GetOperationStateResponse> {
+    static async getOperationState(context: TurnContext, operationId: string): Promise<BatchOperationStateResponse> {
         if (!operationId) {
             throw new Error('operationId is required.');
         }
@@ -510,7 +510,7 @@ export class TeamsInfo {
      * @param operationId The operationId to get the failed entries of.
      * @returns Promise with the list of failed entries of the operation.
      */
-    static async getFailedEntries(context: TurnContext, operationId: string): Promise<GetFailedEntriesResponse> {
+    static async getFailedEntries(context: TurnContext, operationId: string): Promise<BatchFailedEntriesResponse> {
         if (!operationId) {
             throw new Error('operationId is required.');
         }