Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove old babel/traverse version with a postinstall script #4590

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR removes the old version of @babel/traverse (7.19.4) that is installed by the @microsoft/orchestrator-core package. This version of babel/traverse is vulnerable and botbuilder is also installing a later and secure version of this package (7.23.2).

Specific Changes

  • Added a postinstall script in the root and botbuilder-orchestrator-ai package.json files to remove the old version of babel.

Testing

These images show the dependencies tree before and after running the postinstall script.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 18, 2023 19:16
@coveralls
Copy link

coveralls commented Dec 18, 2023

Pull Request Test Coverage Report for Build 7252764445

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.629%

Totals Coverage Status
Change from base Build 7132486847: 0.0%
Covered Lines: 20373
Relevant Lines: 22803

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 685bdd2 into main Dec 19, 2023
@tracyboehrer tracyboehrer deleted the southworks/fix/remove-babel-old-version branch December 19, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants