Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update axios and fix issue in botframework-connector #4591

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR updates the axios package and replaces it with fetch in botframework-connector due to a breaking change in version 1.x.x of axios.

Specific Changes

  • Updated axios version to ^1.6.0 in botbuilder and botbuilder-core.
  • Replaced axios with fetch in the botFrameworkClientImpl class.

Testing

The following image shows a bot working using CloudAdapter with the botframework-connector fix.
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 21, 2023 20:00
@coveralls
Copy link

coveralls commented Dec 21, 2023

Pull Request Test Coverage Report for Build 7292648238

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 84.541%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-connector/src/auth/botFrameworkClientImpl.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 7289713167: 0.002%
Covered Lines: 20415
Relevant Lines: 22871

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 6efb46d into main Dec 21, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/update-axios branch December 21, 2023 20:19
tracyboehrer pushed a commit that referenced this pull request Dec 21, 2023
# Conflicts:
#	libraries/botframework-connector/package.json
@Hyokune
Copy link

Hyokune commented Dec 28, 2023

Would there be a release for this anytime soon?

@tracyboehrer
Copy link
Member

This will be released the week of Jan 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants