Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BotState cache hash skipped properties #4594

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

sw-joelmut
Copy link
Collaborator

#minor

Description

This PR fixes an issue where the predefined skipped properties were removed from the bot's state cache object, instead of removing them only from the cache hash calculation because of the original issue (#4325).

Specific Changes

  • Updated skipProperties method to not modify the parameter value, and instead generate a copy, so later the hash calculation can use.
  • Updated the unit tests for BeginSkill, showing the properties are no longer deleted from the cache.
  • Added skillClient to the skipped properties.

Testing

The following image shows the current error, and the bot working from the original issue.
image
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner January 3, 2024 17:41
@coveralls
Copy link

coveralls commented Jan 3, 2024

Pull Request Test Coverage Report for Build 7400583236

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 90 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.03%) to 84.511%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 85.34%
libraries/botframework-streaming/src/utilities/createNodeServer.ts 1 82.14%
libraries/botbuilder-dialogs/src/skillDialog.ts 3 84.66%
libraries/botbuilder-dialogs-adaptive/src/actions/beginSkill.ts 5 70.12%
libraries/botframework-streaming/src/namedPipe/namedPipeServer.ts 12 61.64%
libraries/botframework-streaming/src/namedPipe/namedPipeClient.ts 17 45.45%
libraries/botframework-streaming/src/namedPipe/namedPipeTransport.ts 51 34.31%
Totals Coverage Status
Change from base Build 7301953860: -0.03%
Covered Lines: 20408
Relevant Lines: 22872

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 3418fa9 into main Jan 8, 2024
@tracyboehrer tracyboehrer deleted the southworks/fix/skipped-properties branch January 8, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants