Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4786] Clarify createBotFrameworkAuthenticationFromConfiguration usage in yo templates #4856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR updates the signature of the createBotFrameworkAuthenticationFromConfiguration function to allow null values for the Configuration parameter, avoiding an error when using @ts-check or strict setting in TS bots.

Specific Changes

  • Added the null option for the Configuration parameter in createBotFrameworkAuthenticationFromConfiguration.
  • Updated the function signature in botbuilder-core.api.md

Testing

The changes were tested using anonymous and credentials configurations for the bots.
image

These images show the error before the changes and no errors after.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner February 11, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants