Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4853] ConfigurationBotFrameworkAuthentication errors when initialized with process.env #4857

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: [#4853] ConfigurationBotFrameworkAuthentication errors when initialized with process.env #4857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
474455b
Fix config options type to support process.env
sw-joelmut Feb 11, 2025
ecbe9ab
Fix eslint
sw-joelmut Feb 11, 2025
bf47c1f
Fix test:compat
sw-joelmut Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions libraries/botbuilder-core/etc/botbuilder-core.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,13 @@ export class ConfigurationBotFrameworkAuthentication extends BotFrameworkAuthent
createUserTokenClient(claimsIdentity: ClaimsIdentity): Promise<UserTokenClient>;
}

// Warning: (ae-forgotten-export) The symbol "TypedOptions" needs to be exported by the entry point index.d.ts
// Warning: (ae-forgotten-export) The symbol "ZodOptions" needs to be exported by the entry point index.d.ts
//
// @public
export type ConfigurationBotFrameworkAuthenticationOptions = z.infer<typeof TypedOptions>;
export interface ConfigurationBotFrameworkAuthenticationOptions extends ZodOptions {
// (undocumented)
[key: string]: string | boolean | undefined;
}

// @public
export class ConfigurationServiceClientCredentialFactory extends PasswordServiceClientCredentialFactory {
Expand Down
6 changes: 5 additions & 1 deletion libraries/botbuilder-core/src/configurationBotFrameworkAuthentication.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,14 @@ const TypedOptions = z
})
.partial();

type ZodOptions = z.infer<typeof TypedOptions>;

/**
* Contains settings used to configure a [ConfigurationBotFrameworkAuthentication](xref:botbuilder-core.ConfigurationBotFrameworkAuthentication) instance.
*/
export type ConfigurationBotFrameworkAuthenticationOptions = z.infer<typeof TypedOptions>;
export interface ConfigurationBotFrameworkAuthenticationOptions extends ZodOptions {
[key: string]: string | boolean | undefined;
}

/**
* Creates a [BotFrameworkAuthentication](xref:botframework-connector.BotFrameworkAuthentication) instance from an object with the authentication values or a [Configuration](xref:botbuilder-dialogs-adaptive-runtime-core.Configuration) instance.
Expand Down
Loading