Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function calls #21

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add function calls #21

wants to merge 6 commits into from

Conversation

siddharth-krishna
Copy link
Collaborator

Added a special "FnCall" op type to represent a function call. The subfunction of this op points to the function being called.

santhnm2
santhnm2 approved these changes Mar 16, 2021
View reviewed changes
Copy link
Collaborator

@santhnm2 santhnm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this! The only suggestion I have is to maybe add code to the prettyprinter so that we can view functions similar to the hand-written examples we've been discussing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhnm2 santhnm2 santhnm2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharth-krishna @santhnm2