fix namespaces + small rewrite for better readability

microsoft · Apr 10, 2024 · a3d3799 · a3d3799
1 parent e80a6c8
commit a3d3799
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/src/Analyzers/Orchestration/DateTimeOrchestrationAnalyzer.cs b/src/Analyzers/Orchestration/DateTimeOrchestrationAnalyzer.cs
@@ -42,8 +42,12 @@ protected override void RegisterAdditionalCompilationStartAction(CompilationStar
             var operation = (IPropertyReferenceOperation)ctx.Operation;
             IPropertySymbol property = operation.Property;
 
-            if (property.ContainingSymbol.Equals(systemDateTimeSymbol, SymbolEqualityComparer.Default) &&
-                property.Name is nameof(DateTime.Now) or nameof(DateTime.UtcNow) or nameof(DateTime.Today))
+            if (!property.ContainingSymbol.Equals(systemDateTimeSymbol, SymbolEqualityComparer.Default))
+            {
+                return;
+            }
+
+            if (property.Name is nameof(DateTime.Now) or nameof(DateTime.UtcNow) or nameof(DateTime.Today))
             {
                 ISymbol method = ctx.ContainingSymbol;
                 dateTimeUsage.Add((method, operation));

diff --git a/test/Analyzers.Tests/Orchestration/DateTimeOrchestrationAnalyzerTests.cs b/test/Analyzers.Tests/Orchestration/DateTimeOrchestrationAnalyzerTests.cs
@@ -4,9 +4,9 @@
 using Microsoft.CodeAnalysis.Testing;
 using Microsoft.DurableTask.Analyzers.Orchestration;
 
-using VerifyCS = Microsoft.DurableTask.Analyzers.Test.Verifiers.CSharpAnalyzerVerifier<Microsoft.DurableTask.Analyzers.Orchestration.DateTimeOrchestrationAnalyzer>;
+using VerifyCS = Microsoft.DurableTask.Analyzers.Tests.Verifiers.CSharpAnalyzerVerifier<Microsoft.DurableTask.Analyzers.Orchestration.DateTimeOrchestrationAnalyzer>;
 
-namespace Microsoft.DurableTask.Analyzers.Test.Orchestration;
+namespace Microsoft.DurableTask.Analyzers.Tests.Orchestration;
 
 public class DateTimeOrchestrationAnalyzerTests
 {

diff --git a/test/Analyzers.Tests/Verifiers/CSharpAnalyzerVerifier.Durable.cs b/test/Analyzers.Tests/Verifiers/CSharpAnalyzerVerifier.Durable.cs
@@ -4,7 +4,7 @@
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Testing;
 
-namespace Microsoft.DurableTask.Analyzers.Test.Verifiers;
+namespace Microsoft.DurableTask.Analyzers.Tests.Verifiers;
 
 public static partial class CSharpAnalyzerVerifier<TAnalyzer>
     where TAnalyzer : DiagnosticAnalyzer, new()

diff --git a/test/Analyzers.Tests/Verifiers/CSharpAnalyzerVerifier.cs b/test/Analyzers.Tests/Verifiers/CSharpAnalyzerVerifier.cs
@@ -7,7 +7,7 @@
 using Microsoft.CodeAnalysis.Testing;
 using Microsoft.CodeAnalysis.Testing.Verifiers;
 
-namespace Microsoft.DurableTask.Analyzers.Test.Verifiers;
+namespace Microsoft.DurableTask.Analyzers.Tests.Verifiers;
 
 public static partial class CSharpAnalyzerVerifier<TAnalyzer>
     where TAnalyzer : DiagnosticAnalyzer, new()

diff --git a/test/Analyzers.Tests/Verifiers/CSharpCodeFixVerifier.cs b/test/Analyzers.Tests/Verifiers/CSharpCodeFixVerifier.cs
@@ -8,7 +8,7 @@
 using Microsoft.CodeAnalysis.Testing;
 using Microsoft.CodeAnalysis.Testing.Verifiers;
 
-namespace Microsoft.DurableTask.Analyzers.Test.Verifiers;
+namespace Microsoft.DurableTask.Analyzers.Tests.Verifiers;
 
 public static partial class CSharpCodeFixVerifier<TAnalyzer, TCodeFix>
     where TAnalyzer : DiagnosticAnalyzer, new()