Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
durable task scheduler auth extension support #362
durable task scheduler auth extension support #362
Changes from 54 commits
fc053ec
6f1d2bc
51e39bd
6987f1b
e162815
e19de44
3a6dc52
65dfb85
29445a0
e63f12a
5c72ee7
c6e42c5
6a66aaa
131c575
65fa607
4f45ec5
d4607e4
552a9c8
54dba76
5e97555
9c890c5
49c6282
1adf7cc
14b94eb
5696b2f
62e2b30
02b02c7
ee517d2
34a47ad
2decb79
ee295d0
522d4b0
d289c10
0d2a20c
f4f03fc
59c5e9c
3dfbb72
5083703
a505004
443613e
8744f8a
37d3d5e
c7f499a
f077e98
89b7071
77cd2d9
3af8b62
549e105
3a40d09
c697fbc
55eea54
1ede0d4
02d5992
e0bd4e2
5b4f648
6f28efc
3334130
d87eed6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are targeting net6 but using a v8.x package. While this is technically 'valid', it may be confusing to users. Are we able to use a 6.x package here?
Side note: targeting net8 and using v8.x packages would be another discussion / work item. Don't want to get that tangled into this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v6 of this package does not target dotnet 6, and v7 does not have
validateonstart. v8 is min version targeting dotnet 6 and has validateonstart api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need ValidateOnStart? This will effectively be validated on start, as validation will occur on first import of it, which will be done at start due to this being eventually imported by a
IHostedService
(the DurableTaskWorker)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, updated ver and removed validateonstart