Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add podspec for ListItem #1939

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexanderboswell
Copy link
Contributor

@alexanderboswell alexanderboswell commented Dec 5, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Add ListItem in the podspec file so it can be consumed.

Microsoft Reviewers: Open in CodeFlow

@alexanderboswell alexanderboswell requested a review from a team as a code owner December 5, 2023 06:30
@alexanderboswell alexanderboswell enabled auto-merge (squash) December 5, 2023 06:30
@alexanderboswell
Copy link
Contributor Author

alexanderboswell commented Dec 5, 2023

@huwilkes When I created the ListItem it seemed ideal to use the same tokens as TableViewCell. I do wonder if that doesnt make as much sense anymore because it is required for ListItem - which makes it so you have more needed (which is easy to see now when we define the podspec)

Thoughts?

@huwilkes
Copy link
Collaborator

huwilkes commented Dec 5, 2023

@huwilkes When I created the ListItem it seemed ideal to use the same tokens as TableViewCell. I do wonder if that doesnt make as much sense anymore because it is required for ListItem - which makes it so you have more needed (which is easy to see now when we define the podspec)

Thoughts?

Probably makes sense to move the tokens into their own podspec that both list item and tvc depend on rather than adding a new identical token set.

@lyzhan7 lyzhan7 mentioned this pull request Jun 20, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants