Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve iOS contributing guide #1950

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve iOS contributing guide #1950

wants to merge 1 commit into from

Conversation

imthath-m
Copy link
Contributor

@imthath-m imthath-m commented Jan 24, 2024 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

Improve spelling and grammar in iOS contributing guide

Binary change

No impact in binary

Verification

No testing is required

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@imthath-m imthath-m requested a review from a team as a code owner January 24, 2024 04:49
@imthath-m imthath-m force-pushed the ios-contributing-md branch from 3b2bb1a to aa928d3 Compare January 30, 2024 06:14
@imthath-m
Copy link
Contributor Author

@laminesm Thanks for checking.

Do you know who'll take care of the approval for the workflow? Is that even required for this type of PR?

@laminesm
Copy link
Contributor

@laminesm Thanks for checking.

Do you know who'll take care of the approval for the workflow? Is that even required for this type of PR?

I'm not sure what workflow you're referring to. Everything seems to be in order for this PR though all that's left is to merge it. I can do that for you if you don't have that option.

@imthath-m
Copy link
Contributor Author

@laminesm Nevermind. Last time I checked some workflows were pending. Now its all done.

Kindly go ahead and merge it as I don't have access.

@mischreiber
Copy link
Contributor

Sorry for the delay--looks like your branch will need to be updated. Once that's done, I will complete the merge.

@imthath-m imthath-m force-pushed the ios-contributing-md branch from aa928d3 to fc78af5 Compare February 1, 2024 06:26
@imthath-m
Copy link
Contributor Author

No worries.

Rebase done.

@mischreiber mischreiber enabled auto-merge (squash) February 1, 2024 21:32
auto-merge was automatically disabled February 2, 2024 11:11

Head branch was pushed to by a user without write access

@imthath-m imthath-m force-pushed the ios-contributing-md branch from fc78af5 to 60c5465 Compare February 2, 2024 11:11
@imthath-m
Copy link
Contributor Author

@mischreiber Auto merging now disabled because I rebased latest changes. So this is now at awaiting approval again.
CleanShot 2024-02-02 at 16 44 00@2x

@imthath-m imthath-m force-pushed the ios-contributing-md branch from 60c5465 to b5607c8 Compare February 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laminesm laminesm laminesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imthath-m @laminesm @mischreiber