Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-tag): Added selected state for Tag and InteractionTag #33804

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(react-tag): Added selected state for Tag and InteractionTag #33804

wants to merge 4 commits into from
+253 −19

Conversation

ValentinaKozlova
Copy link
Contributor

@ValentinaKozlova ValentinaKozlova commented Feb 7, 2025 •
edited
Loading

New Behavior

Added selected state for Tag and InteractionTag
image

Variants of selected state (for testing)
image

Related Issue(s)

First part of this feature #33738

@ValentinaKozlova ValentinaKozlova added the Component: Tag v9 Tag component label Feb 7, 2025
@ValentinaKozlova ValentinaKozlova self-assigned this Feb 7, 2025
@ValentinaKozlova ValentinaKozlova force-pushed the feat/react-tag-selected-state branch 2 times, most recently from 58d7bd3 to 707bd31 Compare February 11, 2025 17:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.171 MB
293.127 kB		 1.174 MB
293.611 kB		 3.133 kB
484 B
react-tags
InteractionTag		 15.225 kB
6.165 kB		 15.274 kB
6.179 kB		 49 B
14 B
react-tags
Tag		 29.098 kB
9.559 kB		 29.834 kB
9.728 kB		 736 B
169 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 69.638 kB
20.24 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 224.582 kB
64.913 kB
react-components
react-components: FluentProvider & webLightTheme		 44.473 kB
14.597 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-tag-picker
@fluentui/react-tag-picker - package		 185.663 kB
55.782 kB
react-tags
TagGroup		 82.745 kB
24.532 kB
react-timepicker-compat
TimePicker		 108.551 kB
36.094 kB
🤖 This report was generated against 3d21a9daf9dc81ae71d28e14340a59d9a78c3f5e

@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review February 12, 2025 14:45
@ValentinaKozlova ValentinaKozlova requested review from a team as code owners February 12, 2025 14:45
@ValentinaKozlova ValentinaKozlova force-pushed the feat/react-tag-selected-state branch 2 times, most recently from 1d1d04f to b5b5bb9 Compare February 12, 2025 17:47
@ValentinaKozlova ValentinaKozlova force-pushed the feat/react-tag-selected-state branch from b5b5bb9 to 306c796 Compare February 13, 2025 11:28
@github-actions GitHub Actions
Copy link

Pull request demo site: URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

@sopranopillow sopranopillow Awaiting requested review from sopranopillow

@dmytrokirpa dmytrokirpa Awaiting requested review from dmytrokirpa

At least 1 approving review is required to merge this pull request.

Assignees

@ValentinaKozlova ValentinaKozlova

Labels
Component: Tag v9 Tag component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValentinaKozlova @fabricteam