Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Fix IsTrimmable property #201

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

hwoodiwiss
Copy link
Contributor

This PR fixes the condition gating the IsTrimmable property in the .csproj.

This is related to: microsoft/kiota-dotnet#188

baywet
baywet previously requested changes Feb 4, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the patch version in the csproj and add an entry to the changelog as well please?

@hwoodiwiss
Copy link
Contributor Author

hwoodiwiss commented Feb 4, 2024

Can do, thanks for getting to these so quickly, especially on the weekend!

@hwoodiwiss hwoodiwiss requested a review from baywet February 4, 2024 15:24
@andrueastman andrueastman dismissed baywet’s stale review February 5, 2024 07:03

Changes addressed

@andrueastman andrueastman merged commit 69ef5e1 into microsoft:main Feb 5, 2024
7 checks passed
@hwoodiwiss hwoodiwiss deleted the hwoodiwiss-fix-is-trimmable branch February 5, 2024 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants