NVMe and resource disc testcase fixes #3432
Conversation
SRIKKANTH
force-pushed
the
smyakam/nvme_test_fixes_15_09_2024
branch
from
c7e4a17
to
bd7d0e2
Compare
SRIKKANTH
force-pushed
the
smyakam/nvme_test_fixes_15_09_2024
branch
2 times, most recently
from
f76263a
to
5855bb7
Compare
SRIKKANTH
force-pushed
the
smyakam/nvme_test_fixes_15_09_2024
branch
5 times, most recently
from
b402609
to
b29f14e
Compare
SRIKKANTH
changed the title
| f"'WARNING: THIS IS A TEMPORARY DISK' should be present in {file_path}", | ||
| ).contains("WARNING: THIS IS A TEMPORARY DISK") | ||
| node_disc = node.features[Disk] | ||
| resource_disks = node_disc.get_resource_disks() |
There was a problem hiding this comment.
Add a method in Disk feature, called like get_disk_controller_type, and it accept mount point as a parameter. Please also reduce duplicate code with existing get_os_disk_controller_type.
There was a problem hiding this comment.
Please refine get_os_disk_controller_type to use the same logic. You can see the get_os_disk_controller_type contains logic for FreeBSD too. If you implement another get_resource_disk_type. The FreeBSD needs to fix the new failure again.
There was a problem hiding this comment.
Added new method "get_disc_type" to re-use in both get_os_disk_controller_type and get_resource_disk_type
There was a problem hiding this comment.
Please use disk instead of disc to keep consistent.
| resource_disks = node_disc.get_resource_disks() | ||
| if not resource_disks: | ||
| raise LisaException("Resource disk not found") | ||
| if "nvme" in resource_disks[0]: |
There was a problem hiding this comment.
As above comments, use the type enum, instead of checking by string.
There was a problem hiding this comment.
Introduced new constants for NVMe and SCSI resource disc types.
There was a problem hiding this comment.
New constants are right, but enum is needed too.
There was a problem hiding this comment.
Fixed as suggested
NVMe and resource disc testcase fixes 1. Added new testcase "Nvme.verify_nvme_function_unpartitioned". 2. NVMe test case fixes for disc controller type NVMe. 3. Resource disc testcases fixes for VMs with Local NVMEs. 4. "Nvme.verify_nvme_fstrim" - use fstrim testfile size based on available space.
SRIKKANTH
force-pushed
the
smyakam/nvme_test_fixes_15_09_2024
branch
from
cda3e20
to
0756836
Compare
lisa/features/disks.py
Outdated
| return [] | ||
|
|
||
| def get_resource_disk_type(self) -> str: | ||
| return "" |
There was a problem hiding this comment.
It should be RESOURCE_DISK_TYPE_SCSI by default. The empty string is confusing. Actually, an enumeration is better to prevent misuse of a type.
NVMe and resource disc testcase fixes