Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite BPF performance YAML to build and test on all platforms #71

Merged
merged 12 commits into from
Feb 23, 2024
Merged

Rewrite BPF performance YAML to build and test on all platforms #71

merged 12 commits into from
Feb 23, 2024

Conversation

Alan-Jowett
Copy link
Member

Add support for using the reusable build yaml from the ebpf-for-windows repo to build and test eBPF.

Alan Jowett added 2 commits February 16, 2024 11:44
Strip non-CSV lines
7b649cd 
Signed-off-by: Alan Jowett <[email protected]>
Fix typo
f842653 
Signed-off-by: Alan Jowett <[email protected]>
Switch to self-hosted runners
2b4763a 
Signed-off-by: Alan Jowett <[email protected]>
@nibanks
Copy link
Member

nibanks commented Feb 16, 2024

Looks like it crashed the lab machine?

image

I assume this is going to leave eBPF installed now? Do we need to manually clean this up now?

@Alan-Jowett
Copy link
Member Author

@nibanks Is there a mechanism to upload dumps from this machine? It crashing is unexpected and it would be great to be able to triage it.

Note:
This is the largest scale eBPF tests we have run to date.

Limit test to 4 CPUs
9bcffcb 
Signed-off-by: Alan Jowett <[email protected]>
@Alan-Jowett
Copy link
Member Author

OK, got the dump. It appears as if this is related to the VM having 80 cores. Somewhere eBPF goes wrong if we have > 64 cores...

@Alan-Jowett
Copy link
Member Author

This PR is blocked until microsoft/ebpf-for-windows#3270 is fixed.

@Alan-Jowett
Copy link
Member Author

This PR is blocked until microsoft/ebpf-for-windows#3270 is fixed.

Fix is merged.

@Alan-Jowett Alan-Jowett marked this pull request as ready for review February 20, 2024 04:39
@Alan-Jowett Alan-Jowett marked this pull request as draft February 20, 2024 16:12
@Alan-Jowett
Copy link
Member Author

Moving back to draft as the lab run is still failing.

@Alan-Jowett
Copy link
Member Author

Lab machine was still running eBPF built from commit id a19c39f8c7b891e2e6533adc1bfe0c8008906e35 which still has the bug. For some reason it seems to have fails to uninstall the old version.

Limit to 4 cpus for now
cab08df 
Signed-off-by: Alan Jowett <[email protected]>
@Alan-Jowett
Copy link
Member Author

Blocked on some version of #73 and #74.

@Alan-Jowett
Copy link
Member Author

Removed blocked label as it appears as if this now correctly cleans up the runner.

@Alan-Jowett Alan-Jowett marked this pull request as ready for review February 22, 2024 17:00
PR feedback
6067a7a 
Signed-off-by: Alan Jowett <[email protected]>
nibanks
nibanks approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please note, I don't think we're ready to scale up for every eBPF PR to trigger this yet. Maybe every commit.

@nibanks nibanks merged commit 42abeeb into microsoft:main Feb 23, 2024
6 checks passed
@Alan-Jowett Alan-Jowett deleted the ebpf_build_and_test branch February 23, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProjectsByJackHe ProjectsByJackHe ProjectsByJackHe left review comments

@nibanks nibanks nibanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alan-Jowett @nibanks @ProjectsByJackHe