This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix search space compatibility with JSON #4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Jan 10, 2022
| try: | ||
| return json.loads(content) | ||
| except Exception: | ||
| return yaml.safe_load(content) |
There was a problem hiding this comment.
so the yaml format search space still does not support scientific notation, right?
QuanluZhang
approved these changes
Jan 10, 2022
ultmaster
approved these changes
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of now the latest version of PyYAML (6.0) does not support YAML 1.2, which means it is not fully compatible with JSON.
This has caused multiple problems for NNI: #4450 #4452
The PR partially fixed this bug by trying YAML and JSON loaders consecutively. However if a user uses comment and scientific notation at same time, NNI will still fail.
Since PyYAML has already been working on YAML 1.2 support, I prefer to wait for its update for a perfect fix.
As a reminder, ruamel.yaml supports YAML 1.2, but according to our previous experience it's pip package and conda package have inconsistent APIs, which caused even more problems.
Checklist
docHow to test
Create tricky JSON search space file and make sure it's loaded correctly.