Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Xiaowu/fix bug(embedding bag) #1099

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Merge branch 'main' into xiaowu/fixBug(embedding_bag)

95a24dd
Select commit
Loading
Failed to load commit list.
Draft

[draft] Xiaowu/fix bug(embedding bag) #1099

Merge branch 'main' into xiaowu/fixBug(embedding_bag)
95a24dd
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Advanced Security / lintrunner succeeded Nov 20, 2023 in 5s

9 new alerts

New alerts in code changed by this pull request

  • 5 warnings
  • 4 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 3091 in onnxscript/function_libs/torch_lib/ops/core.py

See this annotation in the file changed.

Code scanning / lintrunner

PYLINT/C0415 Note

Import outside toplevel (torch) (import-outside-toplevel)
See import-outside-toplevel. To disable, use # pylint: disable=import-outside-toplevel

Check notice on line 3119 in onnxscript/function_libs/torch_lib/ops/core.py

See this annotation in the file changed.

Code scanning / lintrunner

PYLINT/C0415 Note

Import outside toplevel (torch) (import-outside-toplevel)
See import-outside-toplevel. To disable, use # pylint: disable=import-outside-toplevel

Check warning on line 3133 in onnxscript/function_libs/torch_lib/ops/core.py

See this annotation in the file changed.

Code scanning / lintrunner

PYLINT/W0612 Warning

Unused variable 'mode' (unused-variable)
See unused-variable. To disable, use # pylint: disable=unused-variable

Check warning on line 3133 in onnxscript/function_libs/torch_lib/ops/core.py

See this annotation in the file changed.

Code scanning / lintrunner

RUFF/F841 Warning

Local variable mode is assigned to but never used.
See https://beta.ruff.rs/docs/rules/

Check notice on line 3051 in onnxscript/function_libs/torch_lib/ops/core.py

See this annotation in the file changed.

Code scanning / lintrunner

PYLINT/C0415 Note

Import outside toplevel (numpy) (import-outside-toplevel)
See import-outside-toplevel. To disable, use # pylint: disable=import-outside-toplevel

Check warning on line 3081 in onnxscript/function_libs/torch_lib/ops/core.py

See this annotation in the file changed.

Code scanning / lintrunner

PYLINT/W0612 Warning

Unused variable 'offset2bag' (unused-variable)
See unused-variable. To disable, use # pylint: disable=unused-variable

Check warning on line 3081 in onnxscript/function_libs/torch_lib/ops/core.py

See this annotation in the file changed.

Code scanning / lintrunner

PYLINT/W0612 Warning

Unused variable 'bag_size' (unused-variable)
See unused-variable. To disable, use # pylint: disable=unused-variable

Check warning on line 3081 in onnxscript/function_libs/torch_lib/ops/core.py

See this annotation in the file changed.

Code scanning / lintrunner

PYLINT/W0612 Warning

Unused variable 'max_indices' (unused-variable)
See unused-variable. To disable, use # pylint: disable=unused-variable

Check notice on line 3144 in onnxscript/function_libs/torch_lib/ops/core.py

See this annotation in the file changed.

Code scanning / lintrunner

PYLINT/R1722 Note

Consider using 'sys.exit' instead (consider-using-sys-exit)
See consider-using-sys-exit. To disable, use # pylint: disable=consider-using-sys-exit