-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[torchlib] Squeeze sym_size #1994
Conversation
…e1f3ad11358331d1/onnxscript/function_libs/torch_lib/ops/core.py#L8086-L8088
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
onnxscript/function_libs/torch_lib/ops/core.py:8088
- The behavior introduced by the addition of
op.Squeeze
should be covered by tests to ensure it works as expected.
return op.Squeeze(op.Shape(self, end=dim + 1, start=dim))
❌ 43 Tests Failed:
View the top 1 failed tests by shortest run time
View the full list of 2 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add Squeeze to aten_sym_size because the output is expected to be 0d.