-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[torchlib] Implement type promotion #2010
base: main
Are you sure you want to change the base?
Conversation
@@ -258,12 +263,13 @@ def aten_addmv( | |||
|
|||
@torch_op("aten::addr", traceable=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
traceonly etc.
❌ 21 Tests Failed:
View the top 2 failed tests by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
@@ -0,0 +1,68 @@ | |||
"""Type promotion functions for op implementations.""" |
Check warning
Code scanning / lintrunner
RUFF/CPY001 Warning
See https://docs.astral.sh/ruff/rules/missing-copyright-notice
@@ -0,0 +1,68 @@ | |||
"""Type promotion functions for op implementations.""" |
Check warning
Code scanning / lintrunner
RUFF/format Warning
@@ -0,0 +1,68 @@ | |||
"""Type promotion functions for op implementations.""" |
Check warning
Code scanning / lintrunner
RUFF-FORMAT/format Warning
@@ -0,0 +1,68 @@ | |||
"""Type promotion functions for op implementations.""" | |||
|
|||
from typing import Sequence |
Check warning
Code scanning / lintrunner
RUFF/I001 Warning
See https://docs.astral.sh/ruff/rules/unsorted-imports
Should we merge a basic version before moving the whole thing to PyTorch so that we don't need to start from scratch? |
Sure! We can do that |
Implement PyTorch type promotion for torchlib functions. Reference https://github.com/pytorch/pytorch/blob/bdd942efd76e74baa5dd0a262f7c843ddfe2e11b/torch/_prims_common/__init__.py#L1160