Fix CI issues due to disconnected 1ES pools and unneeded AzureLogin tasks #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 17, 2024 12:59
benhillis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a lot of fun to figure out...
When we marked the repo as public the 1ES hosted pools that we were previously using lost their linkage to this repository. This meant that PR tasks were not being picked up. The fix for this was to re-create new pools that are scoped to our repo.
The other issue this change resolves is removing the Azure Login task from stages that do not need it. There are still some tasks that do need access to the key vault (to download test VHD's) but this will get the CI in a much better state.