mesh_channel: hide RPC response receiver from callers #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will probably hold this PR for a while to avoid merge conflicts with backport work going on. |
smalis-msft
previously approved these changes
Dec 13, 2024
In the future, RPC channels will typically (always?) use blocking senders to provide backpressure and better support early cancellation. To prepare for this, wrap the RPC response oneshot channel in a separate type which in the future can contain both a blocking send request and the response receiver. Also, hide the internal fields of `Rpc` to give us flexibility there in the future, too.
smalis-msft
previously approved these changes
Jan 8, 2025
smalis-msft
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, RPC channels will typically (always?) use blocking senders to provide backpressure and better support early cancellation.
To prepare for this, wrap the RPC response oneshot channel in a separate type which in the future can contain both a blocking send request and the response receiver.
Also, hide the internal fields of
Rpcto give us flexibility there in the future, too.