fuzz_nvme_driver: fix fuzzer-found bugs #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sanitize the input provided to .read, .write, and .flush to avoid contract violations (`NvmeDriver` is an interface interal to `NvmeDisk`, and it's not useful for the fuzzer to find cases where `NvmeDriver` enforces the contract). * Fuzzer can handle when .read, .write, .flush return an Error (bad input can fail an IO; this is fine). * Graceful check for some bad device behavior, rathern than just crash. This will change behavior of the `NvmeDriver` in prod, but if we see a bad device we will still see key errors in our logs.
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
vm/devices/storage/disk_nvme/nvme_driver/fuzz/fuzz_nvme_driver.rs:108
- The word 'anyhing' is misspelled. It should be 'anything'.
/// error or the executed action. `NvmeDriver` is not intended to be an interface consumed by anyhing ther than `NvmeDisk`, yet the fuzzer targets the driver directly.
smmalis37
reviewed
Dec 22, 2024
vm/devices/storage/disk_nvme/nvme_driver/fuzz/fuzz_nvme_driver.rs
Outdated
Show resolved
Hide resolved
smmalis37
reviewed
Dec 22, 2024
vm/devices/storage/disk_nvme/nvme_driver/fuzz/fuzz_nvme_driver.rs
Outdated
Show resolved
Hide resolved
smalis-msft
reviewed
Dec 26, 2024
smalis-msft
reviewed
Dec 26, 2024
smalis-msft
reviewed
Dec 26, 2024
vm/devices/storage/disk_nvme/nvme_driver/fuzz/fuzz_nvme_driver.rs
Outdated
Show resolved
Hide resolved
smalis-msft
reviewed
Dec 26, 2024
smalis-msft
approved these changes
Jan 8, 2025
|
Trying to understand the TODO comments. Do the tags in these refer to anything specific? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues in the
NvmeDriverfuzzer:NvmeDriveris an interface interal toNvmeDisk, and it's not useful for the fuzzer to find cases whereNvmeDriverenforces the contract).NvmeDriverin prod, but if we see a bad device we will still see key errors in our logs.