Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase underhill_attestation vmgs unit test coverage #618

Merged
merged 13 commits into from
Jan 9, 2025
Merged

Increase underhill_attestation vmgs unit test coverage #618

merged 13 commits into from
Jan 9, 2025

Conversation

mattbodd
Copy link
Contributor

@mattbodd mattbodd commented Jan 7, 2025

This PR:

  • Adds unit tests to the underhill_attestation crate's vmgs module
    • Covers all functions in the vmgs module

@mattbodd mattbodd requested review from a team as code owners January 7, 2025 00:38
daprilik
daprilik approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@daprilik daprilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable set of new test collateral. Cool!

@benhillis benhillis merged commit 483db84 into microsoft:main Jan 9, 2025
25 checks passed
@mattbodd mattbodd deleted the dev/mboddewy/underhill_attestation_vmgs_unit_tests branch January 9, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daprilik daprilik daprilik approved these changes

Assignees

@tjones60 tjones60

@daprilik daprilik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattbodd @daprilik @benhillis @tjones60