Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowey: use typestate pattern for gh variables #643

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

flowey: use typestate pattern for gh variables #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
f4f97df
try and get something working
justus-camp-microsoft Jan 9, 2025
82db3d9
fmt
justus-camp-microsoft Jan 9, 2025
ff116bb
test printing pr event
justus-camp-microsoft Jan 10, 2025
46a3016
plumb through is_object
justus-camp-microsoft Jan 10, 2025
65fed09
Merge branch 'main' into ghcontext_typestate
justus-camp-microsoft Jan 10, 2025
dcfa810
try toJSON instead
justus-camp-microsoft Jan 10, 2025
478329b
try echoing instead?
justus-camp-microsoft Jan 10, 2025
cbdd984
try another strategy
justus-camp-microsoft Jan 10, 2025
db8a9c9
add parentheses
justus-camp-microsoft Jan 10, 2025
c7f63cf
let's try jq
justus-camp-microsoft Jan 10, 2025
e360854
better typestate impl (still needs do_read de-dupe)
justus-camp-microsoft Jan 11, 2025
ebec5e1
plumb is_object through on write path
justus-camp-microsoft Jan 11, 2025
d55fc8a
add from_json
justus-camp-microsoft Jan 13, 2025
f778042
clippy
justus-camp-microsoft Jan 13, 2025
b71c81b
see what happens when the event doesn't exist
justus-camp-microsoft Jan 13, 2025
bfa2abd
remove unused events
justus-camp-microsoft Jan 13, 2025
ff200aa
remove from_json and add back test event
justus-camp-microsoft Jan 13, 2025
1d8e3ff
move event to the right place
justus-camp-microsoft Jan 13, 2025
06bade7
try another way of passing is_object through
justus-camp-microsoft Jan 14, 2025
667fbb5
add comment about not adding further behavior to GhContextVar
justus-camp-microsoft Jan 15, 2025
86f2354
Merge branch 'main' into ghcontext_typestate
justus-camp-microsoft Jan 15, 2025
3aa18b6
move to separate module
justus-camp-microsoft Jan 15, 2025
d88b355
shared helper
justus-camp-microsoft Jan 15, 2025
a5b3562
clippy
justus-camp-microsoft Jan 15, 2025
1cd416e
restructure modules, remove test event
justus-camp-microsoft Jan 16, 2025
c20f33a
move global vars to typestate without removing GhContextVar
justus-camp-microsoft Jan 16, 2025
1395a24
remove ghcontextvar
justus-camp-microsoft Jan 17, 2025
7abe491
submodule structure
justus-camp-microsoft Jan 17, 2025
3f45028
re-introduce custom secrets flow
justus-camp-microsoft Jan 17, 2025
ac30808
Merge branch 'main' into ghcontext_typestate
justus-camp-microsoft Jan 17, 2025
9f7afd1
comments
Jan 24, 2025
440251b
docs
Jan 24, 2025
a293393
doc tests
Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions .github/workflows/openvmm-ci.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading