Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM64] Pass through all unknown MMIO to the host. #652

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

Brian-Perkins
Copy link
Contributor

There are some hardware configurations on ARM64 that are not yet completely described in the MMIO map. Since ARM64 is not expected to do any x86-style legacy device detection probes, pass all MMIO accesses through to the host. If the host does not recognize the address, it will handle the bad access.

@Brian-Perkins Brian-Perkins requested a review from a team as a code owner January 10, 2025 20:42
@github-actions github-actions bot added the release_2411 Targets the release/2411 branch. label Jan 10, 2025
@jstarks
Copy link
Member

jstarks commented Jan 10, 2025

I'd prefer we make this purely a runtime behavior difference at the FallbackMmioDevice level, e.g. make mmio_ranges an Option<Vec<...>> and if it's None then pass everything through. Then just construct the device differently for ARM64 via cfg!() instead of #[cfg()].

@jstarks
Copy link
Member

jstarks commented Jan 10, 2025

Please put this in main, too.

@Brian-Perkins Brian-Perkins merged commit 59dae2e into microsoft:release/2411 Jan 10, 2025
22 checks passed
Brian-Perkins added a commit that referenced this pull request Jan 11, 2025
There are some hardware configurations on ARM64 that are not yet
completely described in the MMIO map. Since ARM64 is not expected to do
any x86-style legacy device detection probes, pass all MMIO accesses
through to the host. If the host does not recognize the address, it will
handle the bad access.

---------

Co-authored-by: Brian Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_2411 Targets the release/2411 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants