Accept MADT and SRAT from the host via DevicePlatformSettings #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprilik
reviewed
Jan 11, 2025
|
you've got some clippy, rustfmt, etc... stuff to fix, but otherwise this seems fine #Resolved |
jstarks
reviewed
Jan 11, 2025
| }; | ||
|
|
||
| // Build the ACPI tables as specified. | ||
| if (build_madt) { |
jstarks
previously approved these changes
Jan 11, 2025
Brian-Perkins
approved these changes
Jan 11, 2025
daprilik
approved these changes
Jan 11, 2025
tjones60
approved these changes
Jan 11, 2025
jstarks
approved these changes
Jan 11, 2025
mebersol
added
the
backport_2411
mebersol
added a commit
to mebersol/openvmm
that referenced
this pull request
Jan 11, 2025
…oft#656) Prefer the MADT/SRAT tables offered by the host through DevicePlatformSettings over self-built tables, when the host is trusted. This allows OpenHCL to support scenarios in which the VMM builds these tables in a device- or scenario-specific way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer the MADT/SRAT tables offered by the host through DevicePlatformSettings over self-built tables, when the host is trusted.
This allows OpenHCL to support scenarios in which the VMM builds these tables in a device- or scenario-specific way.