flowey: only build with LTO on macOS #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To restore build performance of flowey on non-macOS systems, add a trampoline binary to build flowey with LTO only on macOS. Ideally, we'd work around this in a less invasive way, but cargo does not have support for target-specific profile options, target-specific environment variables, target-specific aliases, or anything else I can think of that would help here. (We could also have a config.toml that gets passed to flowey invocations and sets a custom rust flag specifically for macos. However, due to other cargo limitations, that would require that all flowey invocations occur at the root of the workspace, which is annoying.)
daprilik
reviewed
Oct 15, 2024
Where is that? |
Ah, apologies - I meant to refer to the code in I think CI is OK |
|
If I remove the |
|
Ohh, yep, you're right - I was mixing the different approaches we considered. Context switching is hard 😅 |
daprilik
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To restore build performance of flowey on non-macOS systems, add a trampoline binary to build flowey with LTO only on macOS.
Ideally, we'd work around this in a less invasive way, but cargo does not have support for target-specific profile options, target-specific environment variables, target-specific aliases, or anything else I can think of that would help here.
(We could also have a config.toml that gets passed to flowey invocations and sets a custom rust flag specifically for macos. However, due to other cargo limitations, that would require that all flowey invocations occur at the root of the workspace, which is annoying.)