Fix conformance classes #39
Merged
+63
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to using only the default conformance classes and extension-provided conformance classes. Refactor extensions to be located in pcstac.config, so that tests can share the same extensions.
Do this by checking that any conformance class coming from api.stacspec.org has the correct STAC API version.
The only place this is used is in the API documentation.
mmcfarland
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The upgrade to stac_fastapi, which included a change in how conformance classes were calculated, caused some code we had to manually define conformance classes to produce duplicate classes from two different STAC API versions.
These changes use the new stac_fastapi mechanism and default conformances classes, which produce the correct set. The default Filter extension conformance classes are modified to remove
cql-text, which we do not yet support, which coming soon!Test were added to catch if conformance classes are of an incorrect STAC API version. This would have caught this issue, which resulted in two of the same conformances classes with the only difference being the STAC version.
Additionally, the advertised STAC API version advertised on the api docs was updated and set to use the single configured STAC_API_VERSION.
The API version that is found in the OpenAPI docs was moved from 1.1 to 1.2
How Has This Been Tested?
Viewing the conformances classes produced in the landing page of the development server and unit tests.
Checklist:
Please delete options that are not relevant.