fix: hide route calls from tracing (#3032)

microsoft · Oct 24, 2024 · 70d67ad · 70d67ad
1 parent e6e6da4
commit 70d67ad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/Playwright.Tests/TracingTests.cs b/src/Playwright.Tests/TracingTests.cs
@@ -259,7 +259,6 @@ await Context.Tracing.StartAsync(new()
                 "Page.EvaluateAsync",
                 "Page.RouteAsync",
                 "Page.GotoAsync",
-                "Route.ContinueAsync",
                 "Page.GotoAsync"
             };
         Assert.AreEqual(expectedActionApiNames, actualActionApiNames);

diff --git a/src/Playwright/Transport/Connection.cs b/src/Playwright/Transport/Connection.cs
@@ -131,7 +131,7 @@ internal Task<T> SendMessageToServerAsync<T>(
         ChannelOwner @object,
         string method,
         Dictionary<string, object> args = null,
-        bool keepNulls = false) => WrapApiCallAsync(() => InnerSendMessageToServerAsync<T>(@object, method, args, keepNulls));
+        bool keepNulls = false) => WrapApiCallAsync(() => InnerSendMessageToServerAsync<T>(@object, method, args, keepNulls), @object?._isInternalType ?? false);
 
     private async Task<T> InnerSendMessageToServerAsync<T>(
         ChannelOwner @object,
@@ -184,7 +184,7 @@ private async Task<T> InnerSendMessageToServerAsync<T>(
             };
         }
 
-        if (_tracingCount > 0 && frames.Count > 0 && !@object._isInternalType)
+        if (_tracingCount > 0 && frames.Count > 0 && @object.Guid != "localUtils")
         {
             LocalUtils.AddStackToTracingNoReply(frames, id);
         }