Throws exception when preview have wrong utf string #2749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kblok
reviewed
Nov 8, 2023
| } | ||
| catch | ||
| { | ||
| var matchResult = Regex.Match(serverParams.Value.ToString(), "\"preview\":\"(.*)\""); |
There was a problem hiding this comment.
I think there should be a better way to accomplish this. What's the exception you're getting?
There was a problem hiding this comment.
I went ahead here: microsoft/playwright#28038
Investigation: we trimmed wrongly, it ended up in an invalid utf8 char and the .NET JSON parser didn't like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2748
when preview have wrong utf string, syste.text.json cannot convert it to object.
However, the preview only use to print, should not affect the normal operation of the program