feat(roll): roll Playwright to 1.43.0-beta-1711484700000 #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Mar 27, 2024
| @@ -39,9 +39,11 @@ public FrameLocator(Frame parent, string selector) | |||
| _frameSelector = selector; | |||
| } | |||
|
|
|||
| IFrameLocator IFrameLocator.First => new FrameLocator(_frame, $"{_frameSelector} >> nth=0"); | |||
| public IFrameLocator First => new FrameLocator(_frame, $"{_frameSelector} >> nth=0"); | |||
There was a problem hiding this comment.
Note: Explicit vs. Implicit interface implementation. No user-facing changes, just make it more consistent across the codebase.
mxschmitt
force-pushed
the
roll/1.43.0-beta-1711484700000
branch
from
8d5c93d to
9bab140
Compare
yury-s
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2872