feat(roll): roll Playwright to 1.43.0-beta-1712646596000 #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campersau
reviewed
Apr 9, 2024
| @@ -44,6 +44,7 @@ internal class BrowserContext : ChannelOwner, IBrowserContext | |||
| private readonly Dictionary<string, Delegate> _bindings = new(); | |||
| private readonly BrowserContextInitializer _initializer; | |||
| private readonly Tracing _tracing; | |||
| internal readonly HashSet<IPage> _backgroundPages = new(); | |||
There was a problem hiding this comment.
Why does this use a HashSet intead of List?
There was a problem hiding this comment.
Hmm, was following upstream impl, doesn't really matter probably, Java uses a List as well.
dgozman
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added after we rolled the last time.
#2896