Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support self-contained executables #2909

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Apr 15, 2024

Should not be any big logical changes, just safeguards the access to assembly.CodeBase and falls-back to AppContext.BaseDirectory otherwise which is important for the self-contained executables.

#2255

Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should work, would be nice to have a test that proves it works. But if this is not a main scenario for you it seems okay to keep as is.

@mxschmitt
Copy link
Member Author

Tested on macOS and Windows. One thing to note is that playwright.ps1 does not work, this is because its a single executable and the ps1 is looking for Microsoft.Playwright.dll.

Workaround: Microsoft.Playwright.Program.Main(["install"]);

Will keep the issue open for now, but this patch should help the users already a lot.

@mxschmitt mxschmitt merged commit 1561839 into main Apr 15, 2024
11 of 15 checks passed
@mxschmitt mxschmitt deleted the bugfix/support-self-contained-executables branch April 15, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants