Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change the target closed exception public #2985

Closed

Conversation

shuowpro
Copy link

When we make a call to the playwright when the browser is disconnected, the method may throw the TargetClosedException, but due to the TargetClosedException is marked as internal, it is hard to catch this exception as the user. this is a trivial change to make this possible

@mxschmitt
Copy link
Member

We recommend catching PlaywrightException instead and looking at the message if necessary. We don't feel comfortable exposing this exception, since its an internal implementation detail which might change over time (did in the past). Closing by that. Thanks for your understanding!

@mxschmitt mxschmitt closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants