devops(tooling): Fix path to README.md in driver downloader
#2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I followed the directions in `CONTRIBUTING.md` and ran `./build.sh --download-driver`. When it ran `dotnet run --project ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .` I got this following exception: ```bash WARNING: Could not update the browser versions in the README file. This is usually due to the readme file not yet existing for 1.46.0. Could not find a part of the path 'D:\Code\RenderMichael\playwright\README.md'. ``` This fixes the issue for me. I assume it hasn't been hit before because everyone else also has the upstream `playwright` project as well.
|
This would end being a noop, since it would read from the same We could add a flag like |
|
Ah got it. Sorry I didn't look closely enough at what the code was doing. My bad. I can add a flag for that, or to avoid disruptions to flow I can add the inverse |
|
I'll close it since it seem stale. Its just a non-user facing warning, so I think we don't need to perform any action. We could change the text of it if you are interested in making it more clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the directions in
CONTRIBUTING.mdand ran./build.sh --download-driver.When it ran
dotnet run --project ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .I got this following exception:This fixes the issue for me. I assume it hasn't been hit before because everyone else also has the upstream
playwrightproject as well.