Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore GitHub Codespaces BROWSER env var #3068

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Nov 25, 2024

e.g. /vscode/bin/linux-x64/f1a4fb101478ce6ec82fe9627c43efbf9e98c813/bin/helpers/browser.sh which prevents customers from running the getting started on GitHub Codespaces.

We respect the BROWSER env var for legacy reasons.

Fixes #2847

@mxschmitt mxschmitt force-pushed the codespaces-ignore-env branch from 8995b08 to 607f680 Compare November 25, 2024 21:07
@mxschmitt mxschmitt closed this Nov 26, 2024
@mxschmitt mxschmitt reopened this Nov 27, 2024
@mxschmitt mxschmitt merged commit df59854 into main Dec 5, 2024
14 of 15 checks passed
@mxschmitt mxschmitt deleted the codespaces-ignore-env branch December 5, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fresh Playwright for .NET Install Throws 'Invalid browser name'
3 participants