Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: set up docker test and publish for NET 8 and 9 #3077

Closed
wants to merge 1 commit into from

Conversation

timbze
Copy link

@timbze timbze commented Dec 4, 2024

Here is a PR to do docker build testing and publishing for both NET 8 and 9. I have not tested this as it's not trivial to test without setting up docker hub, secrets, etc.

Fixes #3075

  • 9.0-jammy docker image does not exist. I could just change the 2 .sh scripts to exit gracefully when trying to run for that configuration.

@timbze
Copy link
Author

timbze commented Dec 4, 2024

@microsoft-github-policy-service agree

@@ -36,6 +36,13 @@ else
exit 1
fi

# Set default .NET version to net8 if not specified
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove

@timbze
Copy link
Author

timbze commented Dec 4, 2024

The jammy 8.0 test that failed (only 1) is a timeout and I guess not related to this PR

@mxschmitt
Copy link
Member

mxschmitt commented Dec 10, 2024

Thank you for your contribution! We recommend installing it manually on top of our existing image see the docs here since this is a STS version.

@timbze
Copy link
Author

timbze commented Dec 10, 2024

@mxschmitt thank you, I didn't think of it working that simple. Should work for me then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support .NET 9 for docker
2 participants