add net8.0 target #3080
Open
add net8.0 target #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add net8.0 target to projects - fix all compiler warnings introduced by the new targets - removed unneeded dependencies since they are part of the .NET runtime fixes microsoft#3033
|
I assume the test failures are unrelated. |
mus65
commented
Dec 8, 2024
| @@ -184,6 +184,7 @@ dotnet_diagnostic.CA1305.severity = error | |||
| dotnet_diagnostic.CA1307.severity = none | |||
| dotnet_diagnostic.CA1308.severity = none | |||
| dotnet_diagnostic.CA1508.severity = none | |||
| dotnet_diagnostic.CA1510.severity = none | |||
There was a problem hiding this comment.
Disabled CA1510 because the throw helpers are not available on netstandard2.0 and #ifing this is not worth it.
| <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> |
There was a problem hiding this comment.
This is part of the SDK since .NET 5, so unnecessary.
see https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/overview?tabs=net-9
Starting in .NET 5, these analyzers are included with the .NET SDK and you don't need to install them separately.
| @@ -63,7 +63,7 @@ public void ApplyToTest(Test test) | |||
| { | |||
| if (_combinations.Any(combination => | |||
| { | |||
| var requirements = (Enum.GetValues(typeof(Targets)) as Targets[]).Where(x => combination.HasFlag(x)); | |||
| var requirements = ((Targets[])Enum.GetValues(typeof(Targets))).Where(x => combination.HasFlag(x)); | |||
| @@ -204,7 +208,7 @@ public async Task SetInputFilesAsync(IEnumerable<string> files, ElementHandleSet | |||
| { | |||
| throw new PlaywrightException("Cannot set input files to detached element."); | |||
| } | |||
| var converted = await SetInputFilesHelpers.ConvertInputFilesAsync(files, (BrowserContext)frame.Page.Context).ConfigureAwait(false); | |||
| var converted = await SetInputFilesHelpers.ConvertInputFilesAsync(files.ToList(), (BrowserContext)frame.Page.Context).ConfigureAwait(false); | |||
There was a problem hiding this comment.
This API was changed to accept a List because of CA1851.
| Frame for this navigation request is not available, because the request | ||
| was issued before the frame is created. You can check whether the request | ||
| is a navigation request by calling isNavigationRequest() method. | ||
| """); |
| @@ -314,105 +314,78 @@ internal void Dispatch(PlaywrightServerMessage message) | |||
|
|
|||
| private ChannelOwner CreateRemoteObject(string parentGuid, ChannelOwnerType type, string guid, JsonElement? initializer) | |||
| { | |||
| ChannelOwner result = null; | |||
| @@ -399,16 +399,25 @@ internal class VisitorInfo | |||
| internal VisitorInfo() | |||
| { | |||
| Visited = new Dictionary<long, int>(); | |||
| IDGenerator = new ObjectIDGenerator(); | |||
There was a problem hiding this comment.
ObjectIDGeneratoris obsolete since it's part of the BinaryFormatter API. Replaced this with a simple implementation based on dotnet/runtime#98168 (comment) .
| @@ -186,7 +191,7 @@ private static void StartProcessWithUTF8IOEncoding(Process process) | |||
| } | |||
| } | |||
|
|
|||
| private static Task ScheduleTransportTaskAsync(Func<CancellationToken, Task> func, CancellationToken cancellationToken) | |||
| private static Task<Task> ScheduleTransportTaskAsync(Func<CancellationToken, Task> func, CancellationToken cancellationToken) | |||
| @@ -345,7 +344,7 @@ private static object ParseEvaluateResultToExpando(JsonElement result, IDictiona | |||
|
|
|||
| if (result.TryGetProperty("e", out var error)) | |||
| { | |||
| return new Exception(error.GetProperty("s").ToString()); | |||
| return new PlaywrightException(error.GetProperty("s").ToString()); | |||
There was a problem hiding this comment.
To fix CA2201. Not sure if this is OK to change?
| await _process.StandardInput.BaseStream.WriteAsync(ll, 0, 4, _readerCancellationSource.Token).ConfigureAwait(false); | ||
| await _process.StandardInput.BaseStream.WriteAsync(message, 0, len, _readerCancellationSource.Token).ConfigureAwait(false); | ||
| #endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these changes make sense regardless of the multi-targeting. Some of the
#ifs could obviously be avoided by ignoring the warning instead. I opted for#ifalmost everywhere for now.fixes #3033