fix(webSocketRoute): support no trailing slash #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Dec 12, 2024
| { | ||
| globWithBaseURL = new Regex("^http").Replace(globWithBaseURL, "ws"); | ||
| // Allow http(s) baseURL to match ws(s) urls. | ||
| if (!string.IsNullOrEmpty(baseURL) && new Regex("^https?://").IsMatch(baseURL) && new Regex("^wss?://").IsMatch(url)) |
There was a problem hiding this comment.
We should only replace https -> wss, http-> ws, not https -> ws
mxschmitt
force-pushed
the
fix-websocket-relatiove
branch
2 times, most recently
from
755c1e1 to
68913ec
Compare
mxschmitt
force-pushed
the
fix-websocket-relatiove
branch
from
68913ec to
466146e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might affect Java as well.
Relates microsoft/playwright-python#2686.