Merge branch 'main' into patch-1

microsoft · Apr 2, 2024 · 2b63318 · 2b63318
2 parents 159ab52 + 6a10c42
commit 2b63318
Show file tree

Hide file tree

Showing 92 changed files with 3,983 additions and 4,255 deletions.
diff --git a/.azure-pipelines/guardian/SDL/.gdnsuppress b/.azure-pipelines/guardian/SDL/.gdnsuppress
@@ -0,0 +1,105 @@
+{
+  "hydrated": false,
+  "properties": {
+    "helpUri": "https://eng.ms/docs/microsoft-security/security/azure-security/cloudai-security-fundamentals-engineering/security-integration/guardian-wiki/microsoft-guardian/general/suppressions",
+    "hydrationStatus": "This file does not contain identifying data. It is safe to check into your repo. To hydrate this file with identifying data, run `guardian hydrate --help` and follow the guidance."
+  },
+  "version": "1.0.0",
+  "suppressionSets": {
+    "default": {
+      "name": "default",
+      "createdDate": "2024-02-06 21:00:02Z",
+      "lastUpdatedDate": "2024-02-06 21:00:02Z"
+    }
+  },
+  "results": {
+    "bffa73d7410f5963f2538f06124ac5524c076da77867a0a19ccf60e508062dff": {
+      "signature": "bffa73d7410f5963f2538f06124ac5524c076da77867a0a19ccf60e508062dff",
+      "alternativeSignatures": [],
+      "memberOf": [
+        "default"
+      ],
+      "createdDate": "2024-02-06 21:00:02Z"
+    },
+    "964642e3cd0f022d5b63f5d3c467d034df4b1664e58dd132b6cd54c98bdae6a1": {
+      "signature": "964642e3cd0f022d5b63f5d3c467d034df4b1664e58dd132b6cd54c98bdae6a1",
+      "alternativeSignatures": [
+        "f2d5560538c833834ca11e62fa6509618ab5454e1e71faf2847cb6fd07f4c4e0"
+      ],
+      "memberOf": [
+        "default"
+      ],
+      "createdDate": "2024-02-06 21:00:02Z"
+    },
+    "5b0f97262e176cd67207fd63a2c74b9984829286e9229d10efc32d6b73130e37": {
+      "signature": "5b0f97262e176cd67207fd63a2c74b9984829286e9229d10efc32d6b73130e37",
+      "alternativeSignatures": [
+        "29a18985690880b8caeebc339c7d2afd107510838cdc6561c1f5493478712581"
+      ],
+      "memberOf": [
+        "default"
+      ],
+      "createdDate": "2024-02-06 21:00:02Z"
+    },
+    "636fe8a4848f24231e94dc13a238022f90a2894cd47a483e351e467eeb98de52": {
+      "signature": "636fe8a4848f24231e94dc13a238022f90a2894cd47a483e351e467eeb98de52",
+      "alternativeSignatures": [
+        "e20632aa7941af4239fd857f802e05582c841fb9ae84e17c71ca6c7fc713246b"
+      ],
+      "memberOf": [
+        "default"
+      ],
+      "createdDate": "2024-02-06 21:00:02Z"
+    },
+    "67ae7118600b0793ec3f0a58a753888e13ce4badcc15575614ee6aa622e5009c": {
+      "signature": "67ae7118600b0793ec3f0a58a753888e13ce4badcc15575614ee6aa622e5009c",
+      "alternativeSignatures": [
+        "d1e68c2c7d9815f47331dd34c31db2634804b45b078a53d00843082747155ac9"
+      ],
+      "memberOf": [
+        "default"
+      ],
+      "createdDate": "2024-02-06 21:00:02Z"
+    },
+    "9b7d0de03b9e0e0b2711e31df7c804528c357bf5aa2d689fb5a5f42750e84077": {
+      "signature": "9b7d0de03b9e0e0b2711e31df7c804528c357bf5aa2d689fb5a5f42750e84077",
+      "alternativeSignatures": [
+        "e42bf5a49be2b1b815d1fde98ebf9d463fd2e70be1e8ca661f1210ce5b0c4953"
+      ],
+      "memberOf": [
+        "default"
+      ],
+      "createdDate": "2024-02-06 21:00:02Z"
+    },
+    "06ecbceae8bfd10acf8c35f21af3926d172c7930f24a204cc58b61efc6c4c770": {
+      "signature": "06ecbceae8bfd10acf8c35f21af3926d172c7930f24a204cc58b61efc6c4c770",
+      "alternativeSignatures": [
+        "035d6eb1444a809987923a39793fbb1ab9e4462405f38f94bc425c579705a9f2"
+      ],
+      "memberOf": [
+        "default"
+      ],
+      "createdDate": "2024-02-06 21:00:02Z"
+    },
+    "c103671af429c32de81f2dc2e7a92999de88a517d916a8f75c8e37448bb2efe9": {
+      "signature": "c103671af429c32de81f2dc2e7a92999de88a517d916a8f75c8e37448bb2efe9",
+      "alternativeSignatures": [
+        "3f904a503c12b62c2922900a2e689632e06272a815448939b1fdd435bcf74388"
+      ],
+      "memberOf": [
+        "default"
+      ],
+      "createdDate": "2024-02-06 21:00:02Z"
+    },
+    "d1196285a4e64cf6f0f7f22a29bf5b33b540137da1a89ed2af0c880d2a8c1d64": {
+      "signature": "d1196285a4e64cf6f0f7f22a29bf5b33b540137da1a89ed2af0c880d2a8c1d64",
+      "alternativeSignatures": [
+        "1c24094ca9e68a76a81c747853860e46fd139c9f47f0fdbad9133538e7d064b2"
+      ],
+      "memberOf": [
+        "default"
+      ],
+      "createdDate": "2024-02-06 21:00:02Z"
+    }
+  }
+}
diff --git a/.azure-pipelines/publish.yml b/.azure-pipelines/publish.yml
@@ -1,38 +1,57 @@
-# don't trigger for Pull Requests
 pr: none
 
 trigger:
   tags:
     include:
     - '*'
 
-pool:
-  vmImage: ubuntu-latest
+resources:
+  repositories:
+  - repository: 1esPipelines
+    type: git
+    name: 1ESPipelineTemplates/1ESPipelineTemplates
+    ref: refs/tags/release
 
-steps:
-- task: UsePythonVersion@0
-  inputs:
-    versionSpec: '3.8'
-  displayName: 'Use Python'
-
-- script: |
-    python -m pip install --upgrade pip
-    pip install -r local-requirements.txt
-    pip install -e .
-    python setup.py bdist_wheel --all
-  displayName: 'Install & Build'
-
-- task: EsrpRelease@4
-  inputs:
-    ConnectedServiceName: 'Playwright-ESRP'
-    Intent: 'PackageDistribution'
-    ContentType: 'PyPi'
-    ContentSource: 'Folder'
-    FolderLocation: './dist/'
-    WaitForReleaseCompletion: true
-    Owners: '[email protected]'
-    Approvers: '[email protected]'
-    ServiceEndpointUrl: 'https://api.esrp.microsoft.com'
-    MainPublisher: 'Playwright'
-    DomainTenantId: '72f988bf-86f1-41af-91ab-2d7cd011db47'
-  displayName: 'ESRP Release to PIP'
+extends:
+  template: v1/1ES.Official.PipelineTemplate.yml@1esPipelines
+  parameters:
+    pool:
+      name: DevDivPlaywrightAzurePipelinesUbuntu2204
+      os: linux
+    sdl:
+      sourceAnalysisPool:
+        name: DevDivPlaywrightAzurePipelinesWindows2022
+        # The image must be windows-based due to restrictions of the SDL tools. See: https://aka.ms/AAo6v8e
+        # In the case of a windows build, this can be the same as the above pool image.
+        os: windows
+      suppression:
+        suppressionFile: $(Build.SourcesDirectory)\.azure-pipelines\guardian\SDL\.gdnsuppress
+    stages:
+    - stage: Stage
+      jobs:
+      - job: HostJob
+        steps:
+        - task: UsePythonVersion@0
+          inputs:
+            versionSpec: '3.8'
+          displayName: 'Use Python'
+        - script: |
+            python -m pip install --upgrade pip
+            pip install -r local-requirements.txt
+            pip install -e .
+            python setup.py bdist_wheel --all
+          displayName: 'Install & Build'
+        - task: EsrpRelease@4
+          inputs:
+            ConnectedServiceName: 'Playwright-ESRP'
+            Intent: 'PackageDistribution'
+            ContentType: 'PyPi'
+            ContentSource: 'Folder'
+            FolderLocation: './dist/'
+            WaitForReleaseCompletion: true
+            Owners: '[email protected]'
+            Approvers: '[email protected]'
+            ServiceEndpointUrl: 'https://api.esrp.microsoft.com'
+            MainPublisher: 'Playwright'
+            DomainTenantId: '72f988bf-86f1-41af-91ab-2d7cd011db47'
+          displayName: 'ESRP Release to PIP'
diff --git a/.github/ISSUE_TEMPLATE/bug.md b/.github/ISSUE_TEMPLATE/bug.md
diff --git a/.github/ISSUE_TEMPLATE/bug.yml b/.github/ISSUE_TEMPLATE/bug.yml
@@ -0,0 +1,96 @@
+name: Bug Report 🪲
+description: Create a bug report to help us improve
+title: '[Bug]: '
+body:
+  - type: markdown
+    attributes:
+      value: |
+        # Please follow these steps first:
+  - type: markdown
+    attributes:
+      value: |
+        ## Troubleshoot
+        If Playwright is not behaving the way you expect, we'd ask you to look at the [documentation](https://playwright.dev/python/docs/intro) and search the issue tracker for evidence supporting your expectation.
+        Please make reasonable efforts to troubleshoot and rule out issues with your code, the configuration, or any 3rd party libraries you might be using.
+        Playwright offers [several debugging tools](https://playwright.dev/python/docs/debug) that you can use to troubleshoot your issues.
+  - type: markdown
+    attributes:
+      value: |
+        ## Ask for help through appropriate channels
+        If you feel unsure about the cause of the problem, consider asking for help on for example [StackOverflow](https://stackoverflow.com/questions/ask) or our [Discord channel](https://aka.ms/playwright/discord) before posting a bug report. The issue tracker is not a help forum.
+  - type: markdown
+    attributes:
+      value: |
+        ## Make a minimal reproduction
+        To file the report, you will need a GitHub repository with a minimal (but complete) example and simple/clear steps on how to reproduce the bug.
+        The simpler you can make it, the more likely we are to successfully verify and fix the bug.
+  - type: markdown
+    attributes:
+      value: |
+        > [!IMPORTANT]
+        > Bug reports without a minimal reproduction will be rejected.
+
+        ---
+  - type: input
+    id: version
+    attributes:
+      label: Version
+      description: |
+        The version of Playwright you are using.
+        Is it the [latest](https://github.com/microsoft/playwright-python/releases)? Test and see if the bug has already been fixed.
+      placeholder: ex. 1.41.1
+    validations:
+      required: true
+  - type: textarea
+    id: reproduction
+    attributes:
+      label: Steps to reproduce
+      description: Please link to a repository with a minimal reproduction and describe accurately how we can reproduce/verify the bug.
+      value: |
+        Example steps (replace with your own):
+        1. Clone my repo at https://github.com/<myuser>/example
+        2. pip install -r requirements.txt
+        3. python test.py
+        4. You should see the error come up
+    validations:
+      required: true
+  - type: textarea
+    id: expected
+    attributes:
+      label: Expected behavior
+      description: A description of what you expect to happen.
+      placeholder: I expect to see X or Y
+    validations:
+      required: true
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: Actual behavior
+      description: |
+        A clear and concise description of the unexpected behavior.
+        Please include any relevant output here, especially any error messages.
+      placeholder: A bug happened!
+    validations:
+      required: true
+  - type: textarea
+    id: context
+    attributes:
+      label: Additional context
+      description: Anything else that might be relevant
+    validations:
+      required: false
+  - type: textarea
+    id: envinfo
+    attributes:
+      label: Environment
+      description: |
+        Please provide information about the environment you are running in.
+      value: |
+        - Operating System: [Ubuntu 22.04]
+        - CPU: [arm64]
+        - Browser: [All, Chromium, Firefox, WebKit]
+        - Python Version: [3.12]
+        - Other info:
+      render: Text
+    validations:
+      required: true
diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml
@@ -1,3 +1,4 @@
+blank_issues_enabled: false
 contact_links:
   - name: Join our Discord Server
     url: https://aka.ms/playwright/discord

diff --git a/.github/ISSUE_TEMPLATE/documentation.yml b/.github/ISSUE_TEMPLATE/documentation.yml
@@ -0,0 +1,29 @@
+name: Documentation 📖
+description: Submit a request to add or update documentation
+title: '[Docs]: '
+labels: ['Documentation :book:']
+body:
+  - type: markdown
+    attributes:
+      value: |
+        ### Thank you for helping us improve our documentation!
+        Please be sure you are looking at [the Next version of the documentation](https://playwright.dev/python/docs/next/intro) before opening an issue here.
+  - type: textarea
+    id: links
+    attributes:
+      label: Page(s)
+      description: |
+        Links to one or more documentation pages that should be modified.
+        If you are reporting an issue with a specific section of a page, try to link directly to the nearest anchor.
+        If you are suggesting that a new page be created, link to the parent of the proposed page.
+    validations:
+      required: true
+  - type: textarea
+    id: description
+    attributes:
+      label: Description
+      description: |
+        Describe the change you are requesting.
+        If the issue pertains to a single function or matcher, be sure to specify the entire call signature.
+    validations:
+      required: true