Skip to content

Commit

Permalink
nits
Browse files Browse the repository at this point in the history
  • Loading branch information
mxschmitt committed Oct 13, 2023
1 parent fb5932c commit 6fb6ed6
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
python-version: "3.10"
- name: Install dependencies & browsers
run: |
python -m pip install --upgrade pip wheel
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
python setup.py bdist_wheel
Expand Down Expand Up @@ -86,7 +86,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies & browsers
run: |
python -m pip install --upgrade pip wheel
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
python setup.py bdist_wheel
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
python-version: "3.10"
- name: Install dependencies & browsers
run: |
python -m pip install --upgrade pip wheel
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
python setup.py bdist_wheel
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_canary_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
python-version: "3.10"
- name: Install dependencies & browsers
run: |
python -m pip install --upgrade pip wheel
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
- uses: azure/docker-login@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_release_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
platforms: arm64
- name: Install dependencies & browsers
run: |
python -m pip install --upgrade pip wheel
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
- run: ./utils/docker/publish_docker.sh stable
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ source ./env/bin/activate
Install required dependencies:

```sh
python -m pip install --upgrade pip wheel
python -m pip install --upgrade pip
pip install -r local-requirements.txt
```

Expand Down
1 change: 0 additions & 1 deletion local-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ pytest-xdist==3.3.1
requests==2.31.0
service_identity==23.1.0
setuptools==68.2.2
twine==4.0.2
twisted==23.8.0
types-pyOpenSSL==23.2.0.2
wheel==0.41.2
7 changes: 4 additions & 3 deletions tests/test_installation.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,17 @@


def test_install(tmp_path: Path, browser_name: str) -> None:
env_dir = tmp_path / "env"
env = EnvBuilder(with_pip=True)
env.create(env_dir=tmp_path)
context = env.ensure_directories(tmp_path)
env.create(env_dir=env_dir)
context = env.ensure_directories(env_dir)
root = Path(__file__).parent.parent.resolve()
if sys.platform == "win32":
wheelpath = list((root / "dist").glob("playwright*win_amd64*.whl"))[0]
elif sys.platform == "linux":
wheelpath = list((root / "dist").glob("playwright*manylinux1*.whl"))[0]
elif sys.platform == "darwin":
wheelpath = list((root / "dist").glob("playwright*macosx_10_*.whl"))[0]
wheelpath = list((root / "dist").glob("playwright*macosx_*.whl"))[0]
subprocess.check_output(
[
context.env_exe,
Expand Down

0 comments on commit 6fb6ed6

Please sign in to comment.