chore: fix datetime parsing

microsoft · Feb 26, 2024 · a67c336 · a67c336
1 parent a4d5fcc
commit a67c336
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/playwright/_impl/_js_handle.py b/playwright/_impl/_js_handle.py
@@ -205,7 +205,7 @@ def parse_value(value: Any, refs: Optional[Dict[int, Any]] = None) -> Any:
             return a
 
         if "d" in value:
-            return datetime.fromisoformat(value["d"][:-1])
+            return datetime.strptime(value["d"], "%Y-%m-%dT%H:%M:%S.%fZ")
 
         if "o" in value:
             o: Dict = {}

diff --git a/tests/async/test_evaluate.py b/tests/async/test_evaluate.py
@@ -216,17 +216,17 @@ async def test_evaluate_evaluate_date(page: Page) -> None:
     result = await page.evaluate(
         '() => ({ date: new Date("2020-05-27T01:31:38.506Z") })'
     )
-    assert result == {"date": datetime.fromisoformat("2020-05-27T01:31:38.506")}
+    assert result == {"date": datetime.fromisoformat("2020-05-27T01:31:38.506Z")}
 
 
 async def test_evaluate_roundtrip_date(page: Page) -> None:
-    date = datetime.fromisoformat("2020-05-27T01:31:38.506")
+    date = datetime.fromisoformat("2020-05-27T01:31:38.506Z")
     result = await page.evaluate("date => date", date)
     assert result == date
 
 
 async def test_evaluate_jsonvalue_date(page: Page) -> None:
-    date = datetime.fromisoformat("2020-05-27T01:31:38.506")
+    date = datetime.fromisoformat("2020-05-27T01:31:38.506Z")
     result = await page.evaluate(
         '() => ({ date: new Date("2020-05-27T01:31:38.506Z") })'
     )

diff --git a/tests/async/test_jshandle.py b/tests/async/test_jshandle.py
@@ -180,7 +180,9 @@ async def test_jshandle_json_value_work(page: Page) -> None:
 async def test_jshandle_json_value_work_with_dates(page: Page) -> None:
     handle = await page.evaluate_handle('() => new Date("2020-05-27T01:31:38.506Z")')
     json = await handle.json_value()
-    assert json == datetime.fromisoformat("2020-05-27T01:31:38.506")
+    assert json == datetime.strptime(
+        "2020-05-27T01:31:38.506Z", "%Y-%m-%dT%H:%M:%S.%fZ"
+    )
 
 
 async def test_jshandle_json_value_should_work_for_circular_object(page: Page) -> None: