-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add osx-arm64 variant config file #1821
Conversation
I think no way to test it easily, but we release a new Playwright version shortly, so we can then see if it works! |
We have build workflows configured, you. could try to add it there as well: playwright-python/.github/workflows/ci.yml Lines 188 to 207 in 890af94
Can you actually publish Apple Silicon from an amd mac? |
Does the All the |
Just FYI cross compiling with conda-build works by putting the dependencies for the build platforms (osx-64) that need to run during build in the |
Yes it does. By default it builds wheels containing the driver for the current platform/architecture. See here. You can pass
Yes I think thats what we need to do. And then tell conda to invoke setup.py per platform. |
Closing as per above. If anyone wants to revisit this in the future, feel free to create a new PR, thanks! |
Actually let me re-open, things have changed, GitHub now has M1 runners, do you mind adding this to the matrix? Then it should work I believe: https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/ |
Landed in #1745. |
This should be fixed as part of v1.43.0 |
Thanks! |
I didn't have a chance to test this yet -- any idea on how to test this easily?