chore(roll): roll Playwright to 1.38.0 #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
roll/1.38
branch
from
3592cd2 to
6a5c1d2
Compare
yury-s
approved these changes
Sep 15, 2023
mxschmitt
force-pushed
the
roll/1.38
branch
from
5f78245 to
d76312b
Compare
yury-s
approved these changes
Sep 15, 2023
YusukeIwaki
reviewed
Sep 17, 2023
| @@ -69,6 +69,14 @@ async def test_evaluate_transfer_bigint(page: Page) -> None: | |||
| assert await page.evaluate("a => a", 17) == 17 | |||
|
|
|||
|
|
|||
| async def test_should_transfer_maps(page): | |||
| assert await page.evaluate("() => new Map([[1, { test: 42n }]])") == {} | |||
There was a problem hiding this comment.
@mxschmitt Hi, does this mean playwright-python doesn't support transfering Map or Set actually?
Map(1) { 1 => { test: 42n } }
Set(2) { 1, { test: 42n } }
There was a problem hiding this comment.
Hi yes, we decided to not implement Map/Set in the language ports for now. (Then last 2 years nobody asked for it)
There was a problem hiding this comment.
Thank you for sharing about the decision :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2061